Skip to content

Added new constructor for GraphServiceClient - #2388

Merged
Vincent Biret (baywet) merged 6 commits into
microsoftgraph:mainfrom
raghucha:patch-1
Jun 9, 2025
Merged

Added new constructor for GraphServiceClient#2388
Vincent Biret (baywet) merged 6 commits into
microsoftgraph:mainfrom
raghucha:patch-1

Conversation

@raghucha

@raghucha raghucha commented Jun 5, 2025 •
edited by baywet
Loading

Copy link
Copy Markdown
Contributor

fixes #2354

Fixes [#]2354(#2354)

-Allows Us to Overide the default Base URL in use cases such as GCC customers

@raghucha
raghucha requested a review from a team as a code owner June 5, 2025 18:06
@raghucha

raghucha commented Jun 5, 2025

Copy link
Copy Markdown
Contributor Author

Vincent Biret (@baywet) Andrew Omondi (@andrueastman) can you have a look at this PR

baywet
Vincent Biret (baywet) requested changes Jun 5, 2025
View reviewed changes

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Comment thread src/main/java/com/microsoft/graph/serviceclient/GraphServiceClient.java Outdated
baywet
Vincent Biret (baywet) previously approved these changes Jun 5, 2025
View reviewed changes

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

Would you mind replicating the change in beta please?

https://github.com/microsoftgraph/msgraph-beta-sdk-java/blob/f77a1c5ae1394fb4a0fb848a1a6d14322428ac18/src/main/java/com/microsoft/graph/beta/serviceclient/GraphServiceClient.java#L58

@baywet
Vincent Biret (baywet) enabled auto-merge (squash) June 5, 2025 18:31
@raghucha

raghucha commented Jun 5, 2025

Copy link
Copy Markdown
Contributor Author

Vincent Biret (@baywet) Beta Pull Request
beta PR

@baywet

Vincent Biret (baywet) commented Jun 5, 2025

Copy link
Copy Markdown
Member

raghucha thanks for putting the beta PR together. As you can see the CI is failing, I think this is due to a missing import. Can you correct the issue please?

auto-merge was automatically disabled June 5, 2025 19:43

Head branch was pushed to by a user without write access

baywet
Vincent Biret (baywet) previously approved these changes Jun 5, 2025
View reviewed changes

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet
Vincent Biret (baywet) enabled auto-merge (squash) June 5, 2025 19:45
auto-merge was automatically disabled June 9, 2025 13:10

Head branch was pushed to by a user without write access

baywet
Vincent Biret (baywet) requested changes Jun 9, 2025
View reviewed changes
Comment thread src/main/java/com/microsoft/graph/serviceclient/GraphServiceClient.java Outdated
baywet
Vincent Biret (baywet) approved these changes Jun 9, 2025
View reviewed changes

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

Could you replicate the changes in beta please?

@baywet
Vincent Biret (baywet) enabled auto-merge (squash) June 9, 2025 15:26
@baywet
Vincent Biret (baywet) merged commit 791479f into microsoftgraph:main Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peombwa Peter Ombwa (peombwa) peombwa left review comments
@baywet Vincent Biret (baywet) baywet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Currently Graph api does not support custom Graph Url

3 participants

@raghucha @baywet @peombwa